Skip to content

#38, #40 Use reflection for robust resolving parent class #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

#38, #40 Use reflection for robust resolving parent class #39

wants to merge 3 commits into from

Conversation

Hubbitus
Copy link
Contributor

@Hubbitus Hubbitus commented Jan 5, 2022 •
edited
Loading

Closes #38, #40

@Hubbitus Hubbitus changed the title #38 Try search parent class in the same namespace #38, #40 Use reflection for robust resolving parent class Jan 5, 2022
@Hubbitus Hubbitus mentioned this pull request Jan 5, 2022
Closed
@nick-zh
Copy link
Member

nick-zh commented Jan 5, 2022

I think the alias fix is missing here

@Hubbitus
Copy link
Contributor Author

Hubbitus commented Jan 8, 2022

@nick-zh, what do you mean under missed alias fix? I hope the used approach with reflection should cover almost all use cases.

@nick-zh
Copy link
Member

nick-zh commented Jan 8, 2022

I think you had some code regarding aliased classes, but you might be right, the Reflection approach might not need additional code for that 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ParserClass do not resolve parent classes without use statements
2 participants
@Hubbitus @nick-zh